Skip to content

Fix page crash caused by BillingAlert component #5220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2024
Merged

Fix page crash caused by BillingAlert component #5220

merged 1 commit into from
Oct 29, 2024

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 29, 2024 •
edited by pr-codex bot
Loading

Fixes: DASH-356

PR-Codex overview

This PR primarily focuses on enhancing the RecurringPaymentFailureAlert and BillingAlertsUI components by improving the layout and error handling, as well as replacing some components for better semantic structure.

Detailed summary

  • Changed <Text> to <span> in RecurringPaymentFailureAlert.
  • Updated layout of buttons in RecurringPaymentFailureAlert and AddPaymentNotification.
  • Added ErrorBoundary to BillingAlertsUI for error handling.
  • Replaced useDisclosure with local state for managing modal visibility.
  • Integrated Sentry for error tracking in BillingAlertsErrorBoundary.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 6:15pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 29, 2024 6:15pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 29, 2024 6:15pm
wallet-ui ⬜️ Skipped (Inspect) Oct 29, 2024 6:15pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 October 29, 2024 18:01 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 29, 2024 18:01 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 29, 2024 18:01 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 29, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 29, 2024
@MananTank Graphite App
Copy link
Member Author

MananTank commented Oct 29, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@linear
Copy link

linear bot commented Oct 29, 2024

DASH-356 PRO: The legacy dashboard is crashing when showing certain billing alerts

@MananTank MananTank marked this pull request as ready for review October 29, 2024 18:02
@codecov
Copy link

codecov bot commented Oct 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.29%. Comparing base (c8b5780) to head (71a21e1).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5220   +/-   ##
=======================================
  Coverage   45.29%   45.29%           
=======================================
  Files        1067     1067           
  Lines       55341    55341           
  Branches     3973     3973           
=======================================
  Hits        25068    25068           
  Misses      29581    29581           
  Partials      692      692
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from c8b5780
packages 40.30% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43 KB (0%) 861 ms (0%) 314 ms (+3.38% 🔺) 1.2 s
thirdweb (cjs) 102.91 KB (0%) 2.1 s (0%) 480 ms (+2.25% 🔺) 2.6 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 27 ms (+38.64% 🔺) 124 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 12 ms (+67% 🔺) 22 ms
thirdweb/react (minimal + tree-shaking) 17.38 KB (0%) 348 ms (0%) 45 ms (+15.04% 🔺) 393 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 29, 2024 •
edited
Loading

Merge activity

@jnsdls jnsdls force-pushed the 10-29-fix_page_crash_caused_by_billingalert_component branch from bd0c6bd to 71a21e1 Compare October 29, 2024 18:12
@changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2024

⚠️ No Changeset found

Latest commit: 71a21e1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – docs-v2 October 29, 2024 18:12 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 29, 2024 18:12 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 29, 2024 18:12 Inactive
@graphite-app graphite-app bot merged commit 71a21e1 into main Oct 29, 2024
30 checks passed
@graphite-app graphite-app bot deleted the 10-29-fix_page_crash_caused_by_billingalert_component branch October 29, 2024 18:15
@vercel vercel bot temporarily deployed to Production – docs-v2 October 29, 2024 18:15 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 29, 2024 18:15 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui October 29, 2024 18:15 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls approved these changes

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

Assignees

No one assigned

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @jnsdls